Bash script "Automated TAF to MP3 converter"

Software TeddyCloud
5

Hi,
i would need some help to make it run.
i created the bash file as described and now when i run:

sudo sh _convert.sh

it gives me:

-e Automated TAF to MP3 converter v1.1

_convert.sh: 130: Syntax error: redirection unexpected

and it only creates the tonies.json in the folder but nothing more.

what i did so far:

apt install jq -y 
apt install ffmpeg 
apt install imagemagick
apt install python3-protobuf

the paths in the _convert.sh are adjusted as follows:

OPUS2TONIE="opus2tonie-main/opus2tonie.py"
SOURCE="audioID/"
TARGET="Tonies2MP3/"
TMP=".tmp"

for a test it is now all in the same folder as the _convert.sh. i copied also the audioID folder with the TAFs from teddycloud.

6

if you run it with sudo, it may use a different shell.

can you try this:

sudo bash ./script.sh

Cheerse

7

thank you! now it is running.
but it stops when it comes to mkdir for each TAF. it says unable to create folder: file or folder not found
do i need to give it permissions? how?

8

i used i using full path. maybe is related to your relative path usage.
Can you try to set full path?

9

yes, it worked. now it creates the folders, but they remain empty.
the script stops again at access to '*.opus' not possible: file or folder not found

i already tried with absolute and relative paths…

10

the TAF is split by using the Opus2Tonie script. the resulting opus files are saved into the TMP dir.
Seems that the command $OPUS2TONIE --split "${SOURCE}${AUDIO_ID}.taf does not split the TAF

do you have a final “/” at your source and target path?

SOURCE="/teddycloud/library/by/audioID/"
TARGET="/srv/Transfer/TAF_CONVERTER/Target/"

and please try this for TMP:

TMP="./.tmp"
11 
do you have a final “/” at your source and target path?

yes, and i also tried with TMP="./.tmp"
same result.

i removed the last line of the script rm -rf $TMP and checked the temp files. it is generated and there is a .jpg and tonies.json

12

then the splitting is not done. can you try this inside tmp dir? replace all var with the correct values.
check if opus2tonie returns any errror.

13

now it works, thank you!

you were right, opus did not get any files to work with, i changed opus again to the absolute path and it works.

14

You are welcome.

15

Hi @OliKo
Thanks for the script and possibility to get the files to another medium.

Can you help me with my error?
- AUDIO_ID: 1611138006
- PERFOMER: Winnie Puuh
- ALBUM: Winnie Puuh - Winnie Puuh auf großer Reise
- TRACK: Winnie Puuh auf großer Reise
- Loading Cover art: Ok.
- Get tracknames from JSON: Ok.
- Convert TAF to split MP3: ls: cannot access ‘*.opus’: No such file or directory
Ok.

The folder ‘1611138006 - Winnie Puuh - Winnie Puuh auf großer Reise’ under target was created but is empty.

16

pls see here: Bash script "Automated TAF to MP3 converter" - #10 by OliKo
and the following posts. i think you have the same issue with opus2tonie.
Check tmp dir if taf is splitted to opus files. use absolute path.

1 Like
17

@OliKo thanks again.

My _convert.sh looks like this:

OPUS2TONIE="/srv/Transfer/TAF_CONVERTER/opus2tonie-main/opus2tonie.py"
SOURCE="/var/lib/docker/volumes/teddy_cloud_library/_data/by/audioID/"
TARGET="/srv/Transfer/TAF_CONVERTER/Target/"
TMP="./.tmp"
...
# Clean up
# rm -rf $TMP
exit 0

paths are working:

root@docker:/# cd /srv/Transfer/TAF_CONVERTER/opus2tonie-main/
root@docker:/srv/Transfer/TAF_CONVERTER/opus2tonie-main# cd /
root@docker:/# cd /var/lib/docker/volumes/teddy_cloud_library/_data/by/audioID/
root@docker:/var/lib/docker/volumes/teddy_cloud_library/_data/by/audioID# cd /
root@docker:/# cd /srv/Transfer/TAF_CONVERTER/Target/
root@docker:/srv/Transfer/TAF_CONVERTER/Target#

in the .tmp folder there is only the cover.jpeg & tonies.json created.
So your guess was right.
The execution of the script only leads into: >

root@docker:/srv/Transfer/TAF_CONVERTER/.tmp# $OPUS2TONIE --split "/var/lib/docker/volumes/teddy_cloud_library/_data
/by/audioID/1611138006.taf
> 
---------------
^c
root@docker:/srv/Transfer/TAF_CONVERTER/.tmp# python3 /srv/Transfer/TAF_CONVERTER/opus2tonie-main/opus2tonie.py --split "/var/lib/docker/volumes/teddy_cloud_library/_data/by/audioID/1611138006.taf
>

I have tried to run it direct, with python3 and with python3-protobuf.
But no files are created under .tmp

18

What does the second command return?

1 Like
19

EDIT: Got it
*The line below is the return so in both cases only the „>“ is returned and the script isn’t doing anything more. *
I have to abort it

My fault … thanks is working great.
For the next dumb one. Try to execute opus2tonie.py.
My error was:
File “/srv/Transfer/TAF_CONVERTER/opus2tonie-main/opus2tonie.py”, line 14, in
import tonie_header_pb2
ModuleNotFoundError: No module named ‘tonie_header_pb2’

So git clone https://github.com/bailli/opus2tonie.git the whole thing again and it works. @OliKo Thank you

20

there should be any output like:

root@rasp01 /srv/Transfer/OPUS2Tonie # python opus2tonie.py --info 000.taf
[OK] SHA1 hash: 0x855AA41F8417BFD1351E331AC8FC3F42BE758991
[OK] Timestamp: [0x67373661] 2024-11-15 11:54:09
[OK] Opus data length: 14844727 bytes (~98 kbps)
[OK] Opus header OK || 2 channels || 44.1 kHz || 3627 Ogg pages
[OK] Page alignment OK and size OK

[OK] File is valid

[ii] Total runtime: 00:19:48.11
[ii] 7 Tracks:
  Track 01: 00:03:08.10
  Track 02: 00:03:01.96
  Track 03: 00:01:58.05
  Track 04: 00:03:12.39
  Track 05: 00:02:26.61
  Track 06: 00:03:35.83
  Track 07: 00:02:25.15
root@rasp01 /srv/Transfer/OPUS2Tonie # python opus2tonie.py --split 000.taf
[1/7] 01_000.opus
[2/7] 02_000.opus
[3/7] 03_000.opus
[4/7] 04_000.opus
[5/7] 05_000.opus
[6/7] 06_000.opus
[7/7] 07_000.opus
root@rasp01 /srv/Transfer/OPUS2Tonie #

pls check your python, protobuf and opus2tonie setup.
i think you need “protobuf = 4.21.12” to work with opus2tonie. But ther should be an error pointing to this direction when a newer version is used.

root@rasp01 /srv/Transfer/OPUS2Tonie # pip list | grep protobuf
protobuf                           4.21.12
types-protobuf                     3.20
21

Hi @OliKo great script thank you.
But I was not able to resolve my problem (or even if I don’t believe your code).
My output looks like this so the Track name wasn’t transferred:

'1508506646 - Track #10.mp3' '1508506646 - Track #4.mp3' '1508506646 - Track #8.mp3' '1508506646 - Track #1.mp3' '1508506646 - Track #5.mp3' '1508506646 - Track #9.mp3' '1508506646 - Track #2.mp3' '1508506646 - Track #6.mp3' '1508506646 - Track #3.mp3' '1508506646 - Track #7.mp3'

python3 -c "import pkg_resources; [print(d.project_name, d.version) for d in pkg_resources.working_set if 'protobuf' in d.project_name.lower()]"
protobuf 4.21.12
types-protobuf 3.20

The Track names are under https://raw.githubusercontent.com/toniebox-reverse-engineering/tonies-json/release/tonies.json present.

22

hi it is possible to run the script in a separate container?

23

Please do not mix ‘file name’ and ‘id3 track name’. If a track name is availale at boxine the is stored in id3tag as “Track Name”. file name is always "<audio-id - Track #.mp3
If you don’t want this behavior, feel free to adapt my script. :slight_smile:

24

Yes, i do not run it in a container at all. i run it on a separate linux machine. You only need to have access to the teedycloud content dir.